Add remove account group #1871
Merged
Add remove account group #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
changed the base branch from
main
to
add-account-derivation-for-mnemonic-users
OKendigelyan
force-pushed
the
add-remove-account-group
branch
from
c1eafda to
e2b6d55
Compare
OKendigelyan
force-pushed
the
add-remove-account-group
branch
from
e2b6d55 to
cfecc97
Compare
asiia-trilitech
approved these changes
Sep 11, 2024
| async (_, account) => { | ||
| const user = userEvent.setup(); | ||
| await renderInModal(<AccountSelectorModal />, store); | ||
| const accountLabel = getAccountGroupLabel(account); |
There was a problem hiding this comment.
nit: accountLabel -> groupLabel maybe?
Same for other tests here
| } | ||
| ); | ||
|
|
||
| it("removes mnemonic accounts when confirmed", async () => { |
There was a problem hiding this comment.
Why this test is not grouped with ledger & social?
OKendigelyan
merged commit ce70f0f
into
add-account-derivation-for-mnemonic-users
6 checks passed
OKendigelyan
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Screen.Recording.2024-09-11.at.15.43.02.mov
Checklist