Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional account import feature #1814

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

serjonya-trili
Copy link
Contributor

Proposed changes

Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Screen.Recording.2024-08-29.at.13.20.40.mov
Screen.Recording.2024-08-29.at.13.21.36.mov
Screen.Recording.2024-08-29.at.13.22.25.mov

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:07am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:07am

Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

const color = useColor();
const isMobile = useBreakpointValue({ base: true, lg: false });
const { openWith } = useDynamicModalContext();
const { isOpen: isOnboarding } = useDynamicModalContext();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe isOnboardingOpen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, not sure. I meant exactly like "is the user already onboarding or not" :)

@serjonya-trili serjonya-trili merged commit 17f020b into main Aug 30, 2024
6 checks passed
@serjonya-trili serjonya-trili deleted the add-additional-accounts branch August 30, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants