Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account tile to mobile header #1805

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

OKendigelyan
Copy link
Contributor

@OKendigelyan OKendigelyan commented Aug 29, 2024

Proposed changes

Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Screen.Recording.2024-08-29.at.17.31.01.mov

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-v2-web 🛑 Canceled (Inspect) Aug 29, 2024 4:59pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:59pm

@@ -25,6 +25,7 @@ export const AccountCard = () => {
<AccountTile
background={color("50")}
account={currentAccount}
id="account-tile"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to put it inside account tile component itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this particular AccoundTile to avoid potential future collisions

@OKendigelyan OKendigelyan force-pushed the add-address-tile-to-mobile branch from d78cba6 to fe6eebb Compare August 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants