Fix beacon peers updates #1764
Merged
Fix beacon peers updates #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
serjonya-trili
force-pushed
the
fix-beacon-connection-updates
branch
from
59c6114 to
92d1b92
Compare
| @@ -12,8 +12,8 @@ import { | |||
| } from "@chakra-ui/react"; | |||
| import { useGetConnectionInfo, usePeers, useRemovePeer } from "@umami/state"; | |||
| import { parsePkh } from "@umami/tezos"; | |||
| import { capitalize, noop } from "lodash"; | |||
| import { Fragment, useEffect, useState } from "react"; | |||
| import { capitalize } from "lodash"; | |||
There was a problem hiding this comment.
capitalize from 'lodash/capitalize' please
| }; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Just wondering why have deleted this component?
There was a problem hiding this comment.
just to clean up the code
| }, [refresh]); | ||
|
|
||
| return { peers, refresh }; | ||
| const query = useQuery({ |
There was a problem hiding this comment.
Very elegant solution!
| @@ -108,7 +107,7 @@ export const useAddPeer = () => { | |||
| .deserialize(payload) | |||
| .then(parsePeerInfo) | |||
| .then(peer => WalletClient.addPeer(peer as ExtendedPeerInfo)) | |||
| .then(refresh) | |||
| .then(() => refresh()) | |||
There was a problem hiding this comment.
why not just refresh?
There was a problem hiding this comment.
because it passes its first argument to the refresh function which also has an optional argument which has nothing to do with the peers
| @@ -37,7 +38,9 @@ const customRenderHook = < | |||
| const store = options?.store ?? makeStore(); | |||
|
|
|||
| const Wrapper = ({ children }: PropsWithChildren) => ( | |||
| <Provider store={store}>{children}</Provider> | |||
| <QueryClientProvider client={new QueryClient()}> | |||
There was a problem hiding this comment.
react-query recommends to declare queryClient outside of Wrapper component
serjonya-trili
force-pushed
the
fix-beacon-connection-updates
branch
from
92d1b92 to
2d1132a
Compare
OKendigelyan
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes