Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onboarding flow #1710

Merged
merged 12 commits into from
Aug 28, 2024
Merged

Add onboarding flow #1710

merged 12 commits into from
Aug 28, 2024

Conversation

serjonya-trili
Copy link
Contributor

@serjonya-trili serjonya-trili commented Aug 12, 2024

Proposed changes

This branch will accumulate all changes for the new onboarding screens.

Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Screenshot 2024-08-13 at 09 48 19 Screenshot 2024-08-13 at 09 48 28 Screenshot 2024-08-13 at 09 48 46

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-v2-web ❌ Failed (Inspect) Aug 28, 2024 11:06am
umami-v2-web-storybook ❌ Failed (Inspect) Aug 28, 2024 11:06am

Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Something wrong with layout

<Button width="full" size="lg" variant="primary">
Create a new wallet
</Button>
<Button width="full" size="lg" variant="secondary">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary button and text color doesn't correspond to Figma mockup
image
image

Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serjonya-trili serjonya-trili marked this pull request as ready for review August 28, 2024 11:05
@serjonya-trili serjonya-trili merged commit 25d744a into main Aug 28, 2024
4 of 6 checks passed
@serjonya-trili serjonya-trili deleted the new-onboarding branch August 28, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants