Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embed send operation modal #1644

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

asiia-trilitech
Copy link
Contributor

@asiia-trilitech asiia-trilitech commented Jul 30, 2024

Proposed changes

Task link

This PR updates send operation modal by

  • checking provided operations
  • adding estimated fee
  • adding network & dApp info

This is not the final version as we're still waiting for dApps requests design.

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Screenshots

Screenshot 2024-08-20 at 16 56 31 Screenshot 2024-08-20 at 16 56 41 Screenshot 2024-08-20 at 16 57 21 Screenshot 2024-08-20 at 16 57 29

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:27am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:27am

@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from 8d1d2d2 to 0a2ec8c Compare August 2, 2024 13:06
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from 0a2ec8c to 3f912dd Compare August 20, 2024 14:07
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch 2 times, most recently from dfbcbd9 to c5af4b7 Compare August 20, 2024 16:45
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from 0c58c83 to c8c4b0d Compare August 22, 2024 02:04
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from c8c4b0d to 7f26d73 Compare August 22, 2024 02:12
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from 7f26d73 to a820830 Compare August 22, 2024 02:26
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from a820830 to d9123cb Compare August 22, 2024 02:31
@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from d9123cb to ac97177 Compare August 22, 2024 03:01
Copy link
Contributor

@serjonya-trili serjonya-trili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update web accordingly

@asiia-trilitech asiia-trilitech force-pushed the update-embed-send-operation-modal branch from 3e54a80 to c434cb4 Compare August 29, 2024 09:20
@asiia-trilitech asiia-trilitech merged commit 3670c29 into main Aug 29, 2024
6 checks passed
@asiia-trilitech asiia-trilitech deleted the update-embed-send-operation-modal branch August 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants