Add form isValid check for SignButton #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(screen.getByTestId("threshold")).toHaveTextContent("No. of approvals:"); | ||
| }); | ||
|
|
||
| await waitFor(() => { |
There was a problem hiding this comment.
this awaitFor is not needed as the previous one has already processed "all the actions"
serjonya-trili
approved these changes
Jun 10, 2024
OKendigelyan
force-pushed
the
add-disabled-state-to-sign-button
branch
from
b1aed91 to
cdd080e
Compare
OKendigelyan
force-pushed
the
add-disabled-state-to-sign-button
branch
from
cdd080e to
a5cf48e
Compare
Coverage report
Test suite run success1445 tests passing in 187 suites. Report generated by 🧪jest coverage report action from a5cf48e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Checklist