Fix contract origination with Michelson storage #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serjonya-trili
force-pushed
the
fix-contract-origination
branch
from
3edbb17 to
4166baf
Compare
Coverage report
Test suite run success1439 tests passing in 186 suites. Report generated by 🧪jest coverage report action from 2faa531 |
OKendigelyan
reviewed
Jun 6, 2024
src/utils/tezos/helpers.ts
Outdated
| try { | ||
| new Parser().parseJSON(rawStorage); | ||
| return true; | ||
| } catch (_) { |
There was a problem hiding this comment.
Here we can use catch clause without params. No need (_)
|
@serjonya-trili LGTM including one small comment 👍 |
serjonya-trili
force-pushed
the
fix-contract-origination
branch
from
4166baf to
2faa531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
here's the reason why
Types of changes
Steps to reproduce
try to deploy a token here