Add origination operation page #1285
Conversation
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
8bd28c6 to
ba41993
Compare
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
ba41993 to
e0b3caa
Compare
| import { executeOperations, makeToolkit } from "../../../utils/tezos"; | ||
| import { SuccessStep } from "../SuccessStep"; | ||
|
|
||
| const user = userEvent.setup(); |
There was a problem hiding this comment.
it's better to do inside the tests according to this
| expect(screen.getByText(prettyTezAmount(fee))).toBeVisible(); | ||
| }); | ||
|
|
||
| it("uses correct network", async () => { |
There was a problem hiding this comment.
I think it's enough to check that when you click the button executeOperations gets the correct payload, and the WalletClient too.
this test was written in another component just to make sure that the network selection works correctly, no need to copy it here
| <AccordionIcon /> | ||
| </AccordionButton> | ||
| <AccordionPanel overflowY="auto" maxHeight="300px"> | ||
| <JsValueWrap value={(operation.operations[0] as ContractOrigination).code} /> |
There was a problem hiding this comment.
just do
const {code, storage} = operation.operations[0] as ContractOriginationabove
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
e0b3caa to
8a60fd2
Compare
Coverage report
Test suite run success1402 tests passing in 183 suites. Report generated by 🧪jest coverage report action from e168d7a |
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
8a60fd2 to
6ba0dee
Compare
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
6ba0dee to
567431d
Compare
There was a problem hiding this comment.
nit: the rest of the modals has "Page" suffix - should we maybe rename them to be consistent?
There was a problem hiding this comment.
Thanks for adding the tests 🥇
|
|
||
| it("passes correct payload to sign handler", async () => { | ||
| const user = userEvent.setup(); | ||
| const testToolkit = "testToolkit" as unknown as TezosToolkit; |
There was a problem hiding this comment.
Is it possible to avoid casting to unknown here somehow?
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
3 times, most recently
from
c3ea845 to
da4c206
Compare
OKendigelyan
changed the title
OKendigelyan
force-pushed
the
add-support-for-origination-operations
branch
from
da4c206 to
e168d7a
Compare
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist