Fix secret key import error #1281
Conversation
OKendigelyan
force-pushed
the
fix-secret-key-import-error
branch
from
d1a0b6a to
dbf9166
Compare
Coverage report
Test suite run success1397 tests passing in 181 suites. Report generated by 🧪jest coverage report action from 9baa572 |
| </form> | ||
| {isEncrypted && ( | ||
| <FormControl marginTop="20px" isInvalid={!!errors.password}> | ||
| <PasswordInput data-testid="password" inputName="password" minLength={0} /> |
There was a problem hiding this comment.
Just wanted to check the reasoning for minLength={0}
I think we have minLength=8 in Umami 🤔
However, for random secret keys it makes sense to me to allow different values
There was a problem hiding this comment.
@OKendigelyan could you please add a test for the error being displayed correctly?
And another one for having passwords with length less than 8?
There was a problem hiding this comment.
@asiia-trilitech if I understood you correctly, there is already a test for correct error display - 'shows an error when the password is invalid'.
This implementation assumes any password, so the test for this case already exists - 'shows an error if the password is invalid'.
OKendigelyan
force-pushed
the
fix-secret-key-import-error
branch
from
dbf9166 to
9baa572
Compare
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist