Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social login #1276

Merged
merged 18 commits into from
May 24, 2024
Merged

Add social login #1276

merged 18 commits into from
May 24, 2024

Conversation

serjonya-trili
Copy link
Contributor

@serjonya-trili serjonya-trili commented May 21, 2024

Proposed changes

  • Added facebook, twitter, reddit, and email authentication
  • AddressTileIcon is now a superset of AccountTileIcon which simplifies the logic
  • Where possible, switched from AddressTileIcon usage to AccountTileIcon because we have accounts there anyway
  • Simplified address kind types
  • Improved debug mac build, now it's just 1 command to build the whole app with devtools enabled
  • Added new fake account type - social

Task link

TODO:

  • Update redirect.html
  • Update custom auth to the latest Kukai version
  • Add tests for Auth
  • Add docs for Auth

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

accounts list
Screenshot 2024-05-22 at 11 09 01

Address filter
Screenshot 2024-05-22 at 11 16 57
Screenshot 2024-05-22 at 11 17 03

Address autocomplete suggestions
Screenshot 2024-05-22 at 11 27 30

Sign form
Screenshot 2024-05-22 at 11 28 08

Address fields
Screenshot 2024-05-22 at 11 28 30

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

github-actions bot commented May 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 89.5% 3672/4103
🟢 Branches 81.78% 1270/1553
🟢 Functions 87.73% 1115/1271
🟢 Lines 89.42% 3474/3885

Test suite run success

1437 tests passing in 184 suites.

Report generated by 🧪jest coverage report action from e2390e6

@serjonya-trili serjonya-trili force-pushed the add-social-login branch 2 times, most recently from 886c1cf to 7f3707f Compare May 22, 2024 09:56
@serjonya-trili serjonya-trili marked this pull request as ready for review May 22, 2024 11:32
@serjonya-trili serjonya-trili force-pushed the add-social-login branch 5 times, most recently from 51a06e4 to b7e17a5 Compare May 22, 2024 19:19
@serjonya-trili serjonya-trili merged commit c566448 into main May 24, 2024
4 checks passed
@serjonya-trili serjonya-trili deleted the add-social-login branch May 24, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant