Skip to content

Commit

Permalink
fix: better errors text for WalletConnect
Browse files Browse the repository at this point in the history
  • Loading branch information
dianasavvatina committed Jan 13, 2025
1 parent 112a0e9 commit f058b4d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
7 changes: 7 additions & 0 deletions packages/utils/src/ErrorContext.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ describe("explainTezError", () => {
expect(res).toBe("The delegate is unchanged. Delegation to this address is already done.");
});

it("catches contract.manager.unregistered_delegate", () => {
const res = explainTezError("contract.manager.unregistered_delegate");
expect(res).toBe(
"The provided delegate address is not registered as a delegate. Verify the delegate address and ensure it is active."
);
});

it("returns undefined for unknown errors", () => {
const err = "unknown error";
expect(explainTezError(err)).toBeUndefined();
Expand Down
2 changes: 2 additions & 0 deletions packages/utils/src/ErrorContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export const explainTezError = (err: string): string | undefined => {
return "Emptying an implicit delegated account is not allowed. End delegation before trying again.";
} else if (err.includes("delegate.unchanged")) {
return "The delegate is unchanged. Delegation to this address is already done.";
} else if (err.includes("contract.manager.unregistered_delegate")) {
return "The provided delegate address is not registered as a delegate. Verify the delegate address and ensure it is active.";
} else if (err.includes("michelson_v1.script_rejected")) {
return "The contract code failed to run. Please check the contract.";
}
Expand Down

1 comment on commit f058b4d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title Lines Statements Branches Functions
apps/desktop Coverage: 83%
83.81% (1787/2132) 79.58% (850/1068) 78.27% (454/580)
apps/web Coverage: 83%
83.81% (1787/2132) 79.58% (850/1068) 78.27% (454/580)
packages/components Coverage: 97%
97.51% (196/201) 95.91% (94/98) 88.13% (52/59)
packages/core Coverage: 81%
82.37% (215/261) 72.51% (95/131) 81.66% (49/60)
packages/crypto Coverage: 100%
100% (43/43) 90.9% (10/11) 100% (7/7)
packages/data-polling Coverage: 97%
95.27% (141/148) 87.5% (21/24) 92.85% (39/42)
packages/multisig Coverage: 98%
98.47% (129/131) 85.71% (18/21) 100% (36/36)
packages/social-auth Coverage: 100%
100% (21/21) 100% (11/11) 100% (3/3)
packages/state Coverage: 85%
84.39% (822/974) 81.03% (188/232) 77.77% (301/387)
packages/tezos Coverage: 89%
88.72% (118/133) 94.59% (35/37) 86.84% (33/38)
packages/tzkt Coverage: 89%
87.32% (62/71) 87.5% (14/16) 80.48% (33/41)

Please sign in to comment.