Merge pull request #1478 from trilitech/fix-operations-without-origin…

…ated-contract Fix failed origination tile rendering
trilitech · Jul 10, 2024 · 0644874 · 0644874
2 parents d344522 + 90dd2bb
commit 0644874
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/apps/desktop/src/components/OperationTile/OriginationTile.test.tsx b/apps/desktop/src/components/OperationTile/OriginationTile.test.tsx
@@ -59,6 +59,13 @@ describe("<OriginationTile />", () => {
           );
           expect(screen.getByTestId("title")).toHaveTextContent("Contract Origination");
         });
+
+        it("shows a contract origination title if operation failed and there is no contract", () => {
+          render(fixture(contextValue, originationFixture({ originatedContract: undefined })), {
+            store,
+          });
+          expect(screen.getByTestId("title")).toHaveTextContent("Contract Origination");
+        });
       });
     });
 

diff --git a/apps/desktop/src/components/OperationTile/OriginationTile.tsx b/apps/desktop/src/components/OperationTile/OriginationTile.tsx
@@ -14,7 +14,7 @@ import { AddressPill } from "../AddressPill/AddressPill";
 
 export const OriginationTile = ({ operation }: { operation: OriginationOperation }) => {
   const isMultisig =
-    operation.originatedContract.codeHash === CODE_HASH &&
+    operation.originatedContract?.codeHash === CODE_HASH &&
     operation.originatedContract.typeHash === TYPE_HASH;
 
   const contractTitle = isMultisig ? "Multisig Account Created" : "Contract Origination";

diff --git a/packages/tzkt/src/types.ts b/packages/tzkt/src/types.ts
@@ -151,7 +151,7 @@ export type TransactionOperation = CommonOperationFields & {
 
 export type OriginationOperation = CommonOperationFields & {
   type: "origination";
-  originatedContract: {
+  originatedContract?: {
     address: RawPkh;
     codeHash: number;
     typeHash: number;