fix: Fix method BigmapTypeDetection #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huancheng-trili
force-pushed
the
fix-bigmap-type-detection
branch
from
ccc2941 to
d68eeff
Compare
huancheng-trili
force-pushed
the
fix-bigmap-type-detection
branch
from
d68eeff to
5433e20
Compare
huancheng-trili
force-pushed
the
fix-bigmap-type-detection
branch
from
5433e20 to
d907575
Compare
huancheng-trili
commented
Sep 6, 2024
| @@ -520,10 +518,22 @@ func detectBigmapTypes(p Prim) map[string]Type { | |||
| if n == "" { | |||
| n = "bigmap_" + strconv.Itoa(i) | |||
| } | |||
| if _, ok := named[n]; ok { | |||
| n += "_" + strconv.Itoa(i) | |||
| uniqueName := func(n string) string { | |||
There was a problem hiding this comment.
Updated this just to match the naming convention defined in BigmapTypeDetection. Otherwise, tests would fail due to a mismatch in naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes method
BigmapTypeDetection.Why
One new test case that was added in #16 failed this method.
Test
Uncommented the test case that failed in #16 and all tests passed.