Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the tutorial join-dal-as-baker #480

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Review the tutorial join-dal-as-baker #480

merged 12 commits into from
Dec 17, 2024

Conversation

NicNomadic
Copy link
Collaborator

I followed the tutorial https://docs.tezos.com/tutorials/join-dal-baker and here is what I found.

@NicNomadic NicNomadic requested a review from a team as a code owner November 29, 2024 14:57
@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:18am

timothymcmackin
timothymcmackin requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, just one thing about backticks.

docs/tutorials/join-dal-baker/run-dal-node.md Outdated Show resolved Hide resolved
docs/tutorials/join-dal-baker/run-dal-node.md Outdated Show resolved Hide resolved
@NicNomadic
Copy link
Collaborator Author

On file prepare-account.md:

  • move steps 1-3 to run-node, when they logically belong?
  • note that the faucet get take a long time for 6ktez (more than 1 hour), and it may fail and need to be relaunched

NicNomadic
NicNomadic commented Nov 29, 2024
View reviewed changes
docs/tutorials/join-dal-baker/run-baker.md Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Outdated Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Show resolved Hide resolved
docs/tutorials/join-dal-baker/run-node.md Outdated Show resolved Hide resolved
docs/tutorials/join-dal-baker/run-node.md Outdated Show resolved Hide resolved
NicNomadic
NicNomadic commented Dec 4, 2024
View reviewed changes
Copy link
Collaborator Author

@NicNomadic NicNomadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm preparing an update to handle the issues I've mentioned.

docs/tutorials/join-dal-baker/verify-rights.md Outdated Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Show resolved Hide resolved
docs/tutorials/join-dal-baker/verify-rights.md Show resolved Hide resolved
@NicNomadic NicNomadic assigned NicNomadic and unassigned NicNomadic Dec 9, 2024
@NicNomadic NicNomadic changed the title Reviev the tutorial join-dal-as-baker Review the tutorial join-dal-as-baker Dec 13, 2024
@NicNomadic NicNomadic force-pushed the nic@review-dal-tutorial branch from b412618 to 926b9b3 Compare December 13, 2024 16:24
@NicNomadic NicNomadic force-pushed the nic@review-dal-tutorial branch from 926b9b3 to cf269e7 Compare December 13, 2024 16:30
timothymcmackin
timothymcmackin approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the updated troubleshooting steps are helpful.

@timothymcmackin timothymcmackin merged commit 0939354 into main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezal ezal ezal left review comments

@francoisthire francoisthire francoisthire left review comments

@GuillaumeGen GuillaumeGen GuillaumeGen approved these changes

@timothymcmackin timothymcmackin timothymcmackin approved these changes

Assignees

@NicNomadic NicNomadic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicNomadic @francoisthire @timothymcmackin @ezal @GuillaumeGen