Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages on creating, testing and deploying smart contract #152

Merged
merged 18 commits into from
Nov 16, 2023

Conversation

LiYuxin44
Copy link
Contributor

No description provided.

@LiYuxin44 LiYuxin44 requested a review from a team as a code owner November 3, 2023 16:34
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 2:49pm

Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Here are some thoughts. We can discuss on Monday:

  • Go ahead and put these as pages directly under docs/smart-contracts instead of in the creating-testing-deploying-smart-contract folder.
  • Use sentence-style capitalization for page titles and headings, like "Testing smart contracts."
  • These are independent topics that people may access in any order, so don't refer to things like "in the next chapter" or "in the next section, we will see how to..."
  • Use a more direct style, such as avoiding passive voice in sentences such as "After the smart contract has successfully been originated and included in a baked block, interaction with the contract's entrypoints is possible via command lines."
  • For Testing: What kinds of tests should I create? Check the existing file docs/smart-contracts/testing.md, which is taken from opentezos. There's also info in opentezos on testing frameworks for the different languages and we could provide examples of an automated test in a smartpy contract.
  • For Creating: think about the task of creating a contract from the perspective of a developer, and maybe ask some developers about what they think about and plan for before creating a contract. Do they start from a template or start from scratch? What do they consider before defining the storage and its data types? How do they plan the entrypoints? For example, they probably think of the entrypoints as accepting parameters instead of a parameter and the storage, although when they code it, the entrypoint receives the storage as a parameter.
  • This PR renames the docusaurus start script and installed a different version of docusaurus.
  • This is subjective, but I think it's overdoing it to use bold for an item at the start of lists, as in "- Functionality Tests: Verifying that all contract functions perform as intended under normal conditions." The list will already show up with a bullet and draw attention; overusing bold can make it less effective, but I know that a lot of people use it this way.

Sorry I'm not able to provide more detail now -- github was down for me part of friday.

Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This is headed in the right direction, particularly the testing and deploying pages because they cover some of the steps and the thought process behind the tasks.
  • Go ahead and overwrite the existing testing topic after you take what you want from it instead of creating testing2.md.
  • It doesn't really matter that this PR updates package-lock.json, but ideally a PR shouldn't contain unrelated changes. You can remove the changes with a command like git checkout staging package-lock.json.
  • Make sure you've covered the prerequisites for these tasks. For example, before you can deploy a smart contract, you have to compile it and possibly its initial storage. To use the octez originate command, you need to set up an account in it with some tez to pay the fees. Go over these very carefully and make sure you're not skipping any prereqs or steps.
  • Consistency: make sure headings and list items are parallel in format and style. Some of the headings end in periods and others don't. Some use -ing verbs and others don't.

docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/creating.md Show resolved Hide resolved
docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/deploying.md Outdated Show resolved Hide resolved
docs/smart-contracts/deploying.md Outdated Show resolved Hide resolved
docs/smart-contracts/deploying.md Outdated Show resolved Hide resolved
docs/smart-contracts/testing2.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@timothymcmackin timothymcmackin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, just corrected a few broken links.

docs/smart-contracts/creating.md Outdated Show resolved Hide resolved
docs/smart-contracts/deploying.md Outdated Show resolved Hide resolved
docs/smart-contracts/testing.md Outdated Show resolved Hide resolved
docs/smart-contracts/deploying.md Outdated Show resolved Hide resolved
docs/smart-contracts/testing.md Outdated Show resolved Hide resolved
timothymcmackin
timothymcmackin previously approved these changes Nov 9, 2023
claudebarde
claudebarde previously approved these changes Nov 16, 2023
@timothymcmackin timothymcmackin merged commit c747d1b into staging Nov 16, 2023
1 check passed
@timothymcmackin timothymcmackin deleted the creating-testing-deploying-smart-contract branch November 16, 2023 14:49
timothymcmackin added a commit that referenced this pull request Nov 16, 2023
* pages on creating, testing and deploying smart contract

* fixed file location & language style, recovered package.json and package-lock.json

* Eliminate bold formatting in lists

* updated creating smart contracts

* testing updated

* updated creating and testing

* updated deploying

* New format for dates based on #154

* updated pages

* fix indent

* Update docs/smart-contracts/creating.md

Co-authored-by: Tim McMackin <[email protected]>

* Update docs/smart-contracts/deploying.md

Co-authored-by: Tim McMackin <[email protected]>

* Update docs/smart-contracts/testing.md

Co-authored-by: Tim McMackin <[email protected]>

* Update docs/smart-contracts/testing.md

Co-authored-by: Tim McMackin <[email protected]>

* Update docs/smart-contracts/deploying.md

Co-authored-by: Tim McMackin <[email protected]>

* Interacting with the contract

---------

Co-authored-by: Tim McMackin <[email protected]>
Co-authored-by: Tim McMackin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants