Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Signature of all zero bytes should be Unknown #61

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

emturner
Copy link
Collaborator

Currently defaults to Ed25519, which does not match octez reference

Fixes #50

@emturner emturner force-pushed the emturner@sig-of-zeroes branch 3 times, most recently from 57bf171 to 65a2946 Compare January 2, 2024 09:21
Currently defaults to Ed25519, which does not match octez reference
@emturner emturner force-pushed the emturner@sig-of-zeroes branch from 65a2946 to b86f158 Compare January 2, 2024 09:22
@emturner emturner requested a review from lierdakil January 2, 2024 14:48
@emturner emturner merged commit 18507cf into master Jan 3, 2024
7 checks passed
@emturner emturner deleted the emturner@sig-of-zeroes branch January 3, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base58-encoding signature consisting of all zero bytes produces edsig encoding, which doesn't match reference
2 participants