-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: build/test app on mac #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emturner
reviewed
Oct 20, 2023
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
from
October 20, 2023 14:32
de4bd12
to
4b8711b
Compare
spalmer25
reviewed
Oct 20, 2023
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
from
October 26, 2023 10:40
4b8711b
to
413ba96
Compare
After making required changes, |
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
4 times, most recently
from
October 26, 2023 14:09
5f9543b
to
f80167f
Compare
emturner
reviewed
Oct 26, 2023
emturner
reviewed
Oct 26, 2023
emturner
approved these changes
Oct 26, 2023
v v minor whitespace - can be fixed in future :) |
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
from
October 26, 2023 15:36
f80167f
to
f0375c1
Compare
emturner
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gitconfig change breaks the tests on linux
emturner
force-pushed
the
ajinkyaraj-23@test_derivations
branch
2 times, most recently
from
October 26, 2023 17:17
8273dd7
to
f4d77c0
Compare
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
from
October 30, 2023 15:39
6aa9638
to
3d15e04
Compare
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@test_derivations
branch
from
October 30, 2023 15:50
3d15e04
to
c86d161
Compare
emturner
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sed command removed as it does not support
\U
on Mac (bsd rather than gnu version).