Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: build/test app on mac #73

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Oct 19, 2023

sed command removed as it does not support \U on Mac (bsd rather than gnu version).

Makefile Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch from de4bd12 to 4b8711b Compare October 20, 2023 14:32
Makefile Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch from 4b8711b to 413ba96 Compare October 26, 2023 10:40
@ajinkyaraj-23
Copy link
Collaborator Author

After making required changes,
I am getting one test failure in integration tests.
Please find the test result attached.
integration_tests.json

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch 4 times, most recently from 5f9543b to f80167f Compare October 26, 2023 14:09
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@emturner
Copy link
Collaborator

v v minor whitespace - can be fixed in future :)

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch from f80167f to f0375c1 Compare October 26, 2023 15:36
Copy link
Collaborator

@emturner emturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitconfig change breaks the tests on linux

@emturner emturner force-pushed the ajinkyaraj-23@test_derivations branch 2 times, most recently from 8273dd7 to f4d77c0 Compare October 26, 2023 17:17
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch from 6aa9638 to 3d15e04 Compare October 30, 2023 15:39
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@test_derivations branch from 3d15e04 to c86d161 Compare October 30, 2023 15:50
@emturner emturner merged commit ce88421 into main Oct 31, 2023
55 checks passed
@emturner emturner deleted the ajinkyaraj-23@test_derivations branch October 31, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants