Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nano tests #69

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Merge nano tests #69

merged 9 commits into from
Oct 19, 2023

Conversation

spalmer25
Copy link
Collaborator

No description provided.

@spalmer25 spalmer25 self-assigned this Oct 18, 2023
@spalmer25 spalmer25 linked an issue Oct 18, 2023 that may be closed by this pull request
@spalmer25 spalmer25 force-pushed the palmer@functori@67-merge-nano-tests branch 3 times, most recently from f4c6811 to e901ca7 Compare October 18, 2023 12:50
@spalmer25 spalmer25 marked this pull request as ready for review October 18, 2023 12:52
@spalmer25 spalmer25 requested a review from emturner October 18, 2023 12:52
@spalmer25 spalmer25 force-pushed the palmer@functori@67-merge-nano-tests branch from e901ca7 to 2a3346a Compare October 18, 2023 12:55
mkdir -p tests/samples/operations/nanosp

mkdir -p tests/samples/micheline/nanox
mkdir -p tests/samples/operations/nanox
Copy link
Collaborator

@emturner emturner Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging the generated tests makes sense I think 👍🏻 . In which case it might be worth generating some more? but then splitting them between the three devices potentially.

e.g. could generated 1500, and run 500 on each device

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to run the same tests on each device to make sure that a test fails on a specific device and if we wanted to run more tests, we'd have to do it at a different time from the merge requests CI.
What do you think about it?

Copy link
Collaborator Author

@spalmer25 spalmer25 Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're up for it, I'd like to associate a specific outcome with this change.
#72

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense - let's defer until after we submit the app

@spalmer25 spalmer25 requested a review from emturner October 18, 2023 14:39
@spalmer25 spalmer25 force-pushed the palmer@functori@67-merge-nano-tests branch 4 times, most recently from 32699eb to 1199b29 Compare October 19, 2023 07:38
@spalmer25 spalmer25 force-pushed the palmer@functori@67-merge-nano-tests branch from 1199b29 to a8ac94d Compare October 19, 2023 07:38
@spalmer25 spalmer25 force-pushed the palmer@functori@67-merge-nano-tests branch from a8ac94d to d41d0f7 Compare October 19, 2023 08:11
@spalmer25 spalmer25 merged commit 25b635d into main Oct 19, 2023
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge nano tests
2 participants