-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge nano tests #69
Merge nano tests #69
Conversation
f4c6811
to
e901ca7
Compare
e901ca7
to
2a3346a
Compare
mkdir -p tests/samples/operations/nanosp | ||
|
||
mkdir -p tests/samples/micheline/nanox | ||
mkdir -p tests/samples/operations/nanox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging the generated tests makes sense I think 👍🏻 . In which case it might be worth generating some more? but then splitting them between the three devices potentially.
e.g. could generated 1500, and run 500 on each device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to run the same tests on each device to make sure that a test fails on a specific device and if we wanted to run more tests, we'd have to do it at a different time from the merge requests CI.
What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're up for it, I'd like to associate a specific outcome with this change.
#72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense - let's defer until after we submit the app
32699eb
to
1199b29
Compare
Instead of expect_full_text
In order to reach a failure spot
1199b29
to
a8ac94d
Compare
a8ac94d
to
d41d0f7
Compare
No description provided.