Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] turn app into navigator #304

Draft
wants to merge 12 commits into
base: palmer@functori@sort-and-merge-nano-tests
Choose a base branch
from

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Nov 29, 2024

depends on #303
In test, the TezosAppScreen class has become a class for batching every function needed for tests.
This situation has moved the aim of the tests inside this class, and it has become more difficult to add tests or modify them.

This PR change the responsibility of the TezosAppScreen to a ragger navigator for the Tezos app.
The TezosAppScreen class will be the main code changed when the Touch device tests will be included.

@spalmer25 spalmer25 self-assigned this Nov 29, 2024
@spalmer25 spalmer25 changed the base branch from main to palmer@functori@sort-and-merge-nano-tests November 29, 2024 09:12
@spalmer25 spalmer25 force-pushed the palmer@functori@sort-and-merge-nano-tests branch from 8b81fc8 to 474d918 Compare November 29, 2024 13:01
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch from d28f0b4 to 2982d2a Compare November 29, 2024 14:14
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch from 2982d2a to 5c00ba0 Compare December 9, 2024 08:02
@spalmer25 spalmer25 force-pushed the palmer@functori@sort-and-merge-nano-tests branch from 474d918 to 17226a0 Compare December 9, 2024 08:19
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch 5 times, most recently from 08c07a7 to 8f1126b Compare December 12, 2024 13:21
@spalmer25 spalmer25 force-pushed the palmer@functori@sort-and-merge-nano-tests branch from 17226a0 to 666cf09 Compare December 12, 2024 13:26
@spalmer25 spalmer25 added the tests test - related isues label Dec 12, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@sort-and-merge-nano-tests branch from 666cf09 to b505dfa Compare December 12, 2024 15:38
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch from 8f1126b to b1c4f9b Compare December 12, 2024 15:46
@spalmer25 spalmer25 force-pushed the palmer@functori@sort-and-merge-nano-tests branch from b505dfa to 6a3d0d6 Compare December 13, 2024 11:35
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch 6 times, most recently from 5611fab to 568e8ce Compare December 14, 2024 10:40
Instead of using it directly
+ Move DEFAULT_ACCOUNT and DEFAULT_SEED into `account.py`
 - move functions and value not related to navigator out of `navigator.py`
 - remove
 `test_nanosp_regression_press_right_works_across_apdu_recieves` that
 does not make sens anymore
@spalmer25 spalmer25 force-pushed the palmer@functori@test-turn-app-into-navigator branch from 568e8ce to f3d2381 Compare December 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests test - related isues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant