[nano] remove blind large tx option #297
Conversation
spalmer25
requested review from
ajinkyaraj-23
and removed request for
ajinkyaraj-23
spalmer25
force-pushed
the
palmer@functori@nano-remove-blind-large-tx-option
branch
from
4165523 to
06e3b2e
Compare
- OFF is the default value
Redundant with test_sign_too_long_operation tests
spalmer25
force-pushed
the
palmer@functori@nano-remove-blind-large-tx-option
branch
from
06e3b2e to
b73908b
Compare
| @@ -63,9 +63,14 @@ typedef enum { | |||
| } main_step_t; | |||
|
|
|||
| typedef enum { | |||
| #ifdef HAVE_BAGL | |||
There was a problem hiding this comment.
use bool. there are only two settings so enum does not make sense.
There was a problem hiding this comment.
👍 I will change it when I will apply my commits in your PR
| @@ -76,11 +81,13 @@ typedef enum { | |||
| #define NB_MAX_SCREEN_ALLOWED 8 | |||
| #endif | |||
|
|
|||
| #ifdef HAVE_NBGL | |||
There was a problem hiding this comment.
Are you sure you dont need the reason,
You have to show amount, fees, hash in case of large_tx but only hash in case of parsing error. How do you differenciate the two cases.
There was a problem hiding this comment.
The two flow are different, so no need to differentiate the case later:
- On parsing error the screen are directly displayed then the flow displayed is the blindsigning flow.
- On too-large-operation the flow is the summary flow (finish the parsing before display warning screen)
| @@ -1,238 +0,0 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
where is the test to verify blindsign on behaviour now? for example for screens greater 12/20 for nanox/nanosp, also what happens when parsing error occurs after this limit when blindsigning is on.
There was a problem hiding this comment.
Since the blindsigning flow as been replaced by the too-large-tx flow, the tests regarding blindsigning are for parsing_error, see:
|
The commits of this PR have been merged to the PR #296 |
As followed a discussion with ledger:
This PR
Large txblindsign option for theONblindsigning optionLarge txblindsign option