[blindsign] Ask to blindsign at review #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
added
app::wallet
spalmer25
force-pushed
the
palmer@functori@blindsign-screen-at-blindsign-on
branch
from
7eb7762 to
ff53536
Compare
...nano/snapshots/nanosp/test_blindsign/too_large/not_blind/clear_n_too_large_warning/00022.png
Outdated
Show resolved
Hide resolved
Otherwise, use the clearsign flow as the option was Large Tx
spalmer25
force-pushed
the
palmer@functori@blindsign-screen-at-blindsign-on
branch
from
ff53536 to
3fad340
Compare
ajinkyaraj-23
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #287
This PR:
ONBoth click on it show the summary before asking for sign (or show teh parsing error flow then the blindsign flow after seen a parsing error)
Otherwise, acts like the blindsigning option were
Large TxNanoS+andNanoX(20 -> 12)