Limit the number of screens displayed for signing review for Nano #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
5 times, most recently
from
09b1f0d to
4fd98ff
Compare
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
2 times, most recently
from
2965bee to
c48a9f4
Compare
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
from
c48a9f4 to
0a5faa7
Compare
This was
linked to
issues
Sep 11, 2024
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
2 times, most recently
from
8b1d8eb to
a5f35c6
Compare
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
2 times, most recently
from
8b2df89 to
053ee25
Compare
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
from
053ee25 to
0844499
Compare
- Summary of information provided later
…ee to be dual used for swap and summary. No tests failed and amounts are accurate for both swap and batch transaction. Co-authored-by: Sébastien Palmer <[email protected]>
…tions, total amount and total fee. Co-authored-by: Sébastien Palmer <[email protected]>
- a basic too long operation with many different operations - a too long operation with only transactions - a too long transaction without fee or amount
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
from
0844499 to
92dc2e6
Compare
spalmer25
force-pushed
the
palmer@functori@limit-number-of-screens-displayed-for-review
branch
from
92dc2e6 to
125c3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272 #270 #274
Allow Blindsigning For Large Tx(default): display the too long warning flow and the operation summary flowAllow Blindsigning ON: display the operation summary flowAllow Blindsigning OFF: display normal