Make CI independent of docker registry #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
reviewed
Jan 18, 2024
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@197-make-ci-independent-of-trilitech-artifacts
branch
from
6079817 to
29d321d
Compare
- Ocaml generated tests should not run on Ledger CI.
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@197-make-ci-independent-of-trilitech-artifacts
branch
4 times, most recently
from
a5791f4 to
cdc33e2
Compare
emturner
reviewed
Jan 19, 2024
scripts/test_swap.sh
Outdated
| --rm -v "$(realpath .):/app" \ | ||
| ledger-app-tezos-integration-tests -c \ | ||
| "cd /app && \ | ||
| pip install -r test/python/requirements.txt -q -q && \ |
There was a problem hiding this comment.
-q -q looks weird? could you fix it in a follow up?
There was a problem hiding this comment.
It does look weird but its right syntax for disabling two staged of output except the 'critical'. To disable output entirely its '-q -q -q'
emturner
approved these changes
Jan 19, 2024
- update shell commands as ledger uses alpine linux.
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@197-make-ci-independent-of-trilitech-artifacts
branch
from
cdc33e2 to
f27609d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #197