Add the guidelines github workflow from app-boilerplate #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only had to make minor modifications to get this working. This first to note is that in their
guidelines_enforcer.yml
, we needed to specify that we build things from a subdirectory. After finding that config option, things are much easier.They run
clang --analyze
, so we had to change a few remainingstrcpy(3)
's intostrlcpy(3)
.And, we had to alter the app variant name to
tezos_wallet
and update the app flags to match what Ledger stores upstream in a DB that they maintain to doublecheck that you aren't changing this without filing a PR against said DB. We preserve the existing flags as specified in that DB, but we believe that the flags should be reviewed as: