Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer using deprecated functions #3

Merged
merged 2 commits into from
Jan 22, 2024
Merged

No longer using deprecated functions #3

merged 2 commits into from
Jan 22, 2024

Conversation

spalmer25
Copy link
Collaborator

Replace all deprecated functions with equivalent functions that do not throw exceptions.

@spalmer25 spalmer25 self-assigned this Jan 19, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@replace-deprecated-functions branch from de084cb to 368ad8e Compare January 19, 2024 15:42
@spalmer25 spalmer25 force-pushed the palmer@functori@replace-deprecated-functions branch from 368ad8e to 28a0e0c Compare January 19, 2024 15:43
@spalmer25 spalmer25 marked this pull request as ready for review January 19, 2024 16:19
ajinkyaraj-23
ajinkyaraj-23 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The depreciated functions were failing the static analyzer in ledger workflow.

@ajinkyaraj-23 ajinkyaraj-23 merged commit 198c0e6 into main Jan 22, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@emturner emturner Awaiting requested review from emturner

Assignees

@spalmer25 spalmer25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmer25 @ajinkyaraj-23