Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FLEX #114

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Support FLEX #114

merged 5 commits into from
Jul 17, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Jul 5, 2024

This PR:

  • updates snapshots according to the new STAX display/feature
  • add compilation and tests for FLEX

The settings/info are not displayed well: #115. For example
image
image

The MetaScreen metaclass prevent TezosUseCaseAddressConfirmation to
inherit properly UseCaseAddressConfirmation
@spalmer25 spalmer25 self-assigned this Jul 5, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@support-flex branch from cc73f41 to 496a730 Compare July 11, 2024 14:11
 - screen contains more data: number of screen reduced
 - swipe instead of tap
 - QR button has moved
@spalmer25 spalmer25 force-pushed the palmer@functori@support-flex branch from 496a730 to 6b88917 Compare July 17, 2024 08:06
@spalmer25 spalmer25 force-pushed the palmer@functori@support-flex branch from 6b88917 to 7ffacaf Compare July 17, 2024 08:25
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 July 17, 2024 08:45
@spalmer25 spalmer25 marked this pull request as ready for review July 17, 2024 08:45
@spalmer25 spalmer25 marked this pull request as draft July 17, 2024 08:56
@spalmer25 spalmer25 marked this pull request as ready for review July 17, 2024 08:57
@ajinkyaraj-23
Copy link
Collaborator

Please use usecaseHomeAndSettings in ui_nbgl.c just like i have done for the wallet. Its important to keep the flow according to the guideline.

@spalmer25
Copy link
Collaborator Author

Please use usecaseHomeAndSettings in ui_nbgl.c just like i have done for the wallet. Its important to keep the flow according to the guideline.

Yes absolutely !
I open an issue for that #116

Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmer25 spalmer25 merged commit 2441d38 into main Jul 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants