Context: Expose instruction count #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnyob
changed the title
johnyob
changed the base branch from
ajob410@create-realm-with-default-globals
to
main
johnyob
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
4 times, most recently
from
f8a1509 to
01ae4c4
Compare
johnyob
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
from
53e6ecb to
6941e76
Compare
johnyob
reviewed
Nov 29, 2023
boa_engine/src/error.rs
Outdated
Comment on lines
943
to
822
| unreachable!( | ||
| "The NoInstructionsRemain native error cannot be converted to an opaque type." | ||
| ) | ||
| (constructors.eval_error().prototype(), ErrorKind::Eval) |
There was a problem hiding this comment.
Why do we need to convert the native error into an opaque one? My concern would be that this error could be caught using try-catch
There was a problem hiding this comment.
If the error is thrown async then boa will convert it into an opaque error when it rejects the promise. This causes a panic. If an out of gas error is caught it will immediately be rethrown because you're still out of gas.
sam-finch-tezos
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
2 times, most recently
from
d68e3fc to
4da6387
Compare
sam-finch-tezos
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
from
b8c11dc to
41b24d5
Compare
johnyob
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
from
41b24d5 to
533f6a5
Compare
Test262 conformance changes
|
johnyob
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
2 times, most recently
from
42c4851 to
5ba29ab
Compare
johnyob
force-pushed
the
sam.finch@/context/expose-instruction-count
branch
from
5ba29ab to
e5f312a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the instruction counter and fix a bug allowing unreachable behaviour.
instructions_remainingcounter is a public property.NoInstructionsRemainingerror can now be converted into a javascript error, preventing boa from panicking if the error is thrown async