Implement change-array-by-copy methods (boa-dev#3412)

* Implement `change-array-by-copy` methods * Apply review
trilitech · Nov 29, 2023 · 1da23e4 · 1da23e4
1 parent 919c8a2
commit 1da23e4
Show file tree

Hide file tree

Showing 8 changed files with 980 additions and 368 deletions.
diff --git a/boa_engine/src/builtins/array/mod.rs b/boa_engine/src/builtins/array/mod.rs
diff --git a/boa_engine/src/builtins/array/tests.rs b/boa_engine/src/builtins/array/tests.rs
@@ -874,6 +874,7 @@ fn array_spread_non_iterable() {
 fn get_relative_start() {
     #[track_caller]
     fn assert(context: &mut Context<'_>, arg: Option<&JsValue>, len: u64, expected: u64) {
+        let arg = arg.unwrap_or(&JsValue::Undefined);
         assert_eq!(
             Array::get_relative_start(context, arg, len).unwrap(),
             expected
@@ -900,6 +901,7 @@ fn get_relative_start() {
 fn get_relative_end() {
     #[track_caller]
     fn assert(context: &mut Context<'_>, arg: Option<&JsValue>, len: u64, expected: u64) {
+        let arg = arg.unwrap_or(&JsValue::Undefined);
         assert_eq!(
             Array::get_relative_end(context, arg, len).unwrap(),
             expected