Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Fixing subtle Kokkos use error #9837

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Tpetra: Fixing subtle Kokkos use error #9837

merged 1 commit into from
Oct 21, 2021

Conversation

csiefer2
Copy link
Member

@csiefer2 csiefer2 commented Oct 21, 2021 •
edited
Loading

TESTS: clang debug
Stakeholder feedback: See below
Issue: #9796

@csiefer2 csiefer2 added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 21, 2021
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_intel_17.0.1 to start: Total Wait = 603

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5825
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3370
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3888
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11069
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2525
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1516
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3867
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: python-3

  • Build Num: 503
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: csiefer-6870a3e
  • SHA: 6870a3e
  • Mode: TEST_REPO

Pull Request Author: csiefer2

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5825
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 3370
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3888
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11069
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 2525
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 1516
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3867
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46

Build Information

Test Name: python-3

  • Build Num: 503
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Tpetra;AT: AUTOMERGE
PULLREQUESTNUM 9837
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH csiefer-6870a3e
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 6870a3e
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b6b9d46


CDash Test Results for PR# 9837.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@rppawlo
Copy link
Contributor

rppawlo commented Oct 21, 2021

@csiefer2 - That fixed it! Thanks! Is it worth adding a unit test to tpetra to catch the issue in the future? I guess we would also need a debug clang test in the PR testing too (I'll bring this up at next product leaders meeting).

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit ab51356 into develop Oct 21, 2021
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 9837: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 21, 2021
@ikalash
Copy link
Contributor

ikalash commented Oct 21, 2021

This fixed the errors in Albany! Interestingly we got some timeouts but that might have been due to other things running on the machine at the same time.

ikalash
ikalash reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ikalash ikalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@csiefer2 csiefer2 deleted the csiefer-6870a3e branch October 21, 2021 18:05
@kddevin
Copy link
Contributor

kddevin commented Oct 21, 2021

Wow, subtle. Thank you, @csiefer2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikalash ikalash ikalash left review comments

@rppawlo rppawlo rppawlo approved these changes

@kddevin kddevin Awaiting requested review from kddevin

Assignees
No one assigned
Labels
pkg: Tpetra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csiefer2 @trilinos-autotester @rppawlo @ikalash @kddevin