Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intrepid: Add cmake flag to make clear that Kokkos code is deprecated #4995

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Intrepid: Add cmake flag to make clear that Kokkos code is deprecated #4995

merged 1 commit into from
Apr 24, 2019

Conversation

mperego
Copy link
Contributor

@mperego mperego commented Apr 23, 2019

@trilinos/intrepid

Description

Obsolete Kokkos code in Intrepid had been already disabled.
Now we introduce the cmake option Intrepid_ENABLE_DEPRECATED_KOKKOS_CODE to make it clear that that code is deprecated and it will be removed soon.

Motivation and Context

How Has This Been Tested?

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@mperego mperego requested a review from karapeterson April 23, 2019 22:39
@mperego mperego added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Intrepid labels Apr 23, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3347
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3174
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1619
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1354
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1030
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Using Repos:

Repo: TRILINOS (mperego/Trilinos)
  • Branch: develop
  • SHA: ce43ca1
  • Mode: TEST_REPO

Pull Request Author: mperego

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3347
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3174
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1619
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1354
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1030
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4995
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA ce43ca1
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4d9c273


CDash Test Results for PR# 4995.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

karapeterson
karapeterson approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@karapeterson karapeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ karapeterson ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit fdcb573 into trilinos:develop Apr 24, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4995: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 24, 2019
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karapeterson karapeterson karapeterson approved these changes

Assignees
No one assigned
Labels
pkg: Intrepid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mperego @trilinos-autotester @karapeterson