Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: add additional ETI for normImpl when Tpetra_ENABLE_DEPRECATED_CODE=OFF #4956

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Tpetra: add additional ETI for normImpl when Tpetra_ENABLE_DEPRECATED_CODE=OFF #4956

merged 1 commit into from
Apr 19, 2019

Conversation

kddevin
Copy link
Contributor

@kddevin kddevin commented Apr 18, 2019

@trilinos/tpetra

Description

See #4951
This fix adds scalar = int instantiation for normImpl.
Changes to the default ordinal types caused this class to lack an instantiation.

Motivation and Context

Need to build with Tpetra_ENABLE_DEPRECATED_CODE=OFF and with default ordinal types.

Related Issues

How Has This Been Tested?

Tpetra builds with and without Tpetra_ENABLE_DEPRECATED_CODE=OFF

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@kddevin kddevin added pkg: Tpetra AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Apr 18, 2019
@kddevin kddevin requested a review from mhoemmen April 18, 2019 20:29
@kddevin kddevin self-assigned this Apr 18, 2019
mhoemmen
mhoemmen approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kddevin ! :D

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3317
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3144
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1589
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1324
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1000
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: tpetra_fixNormImplETI
  • SHA: 665ede0
  • Mode: TEST_REPO

Pull Request Author: kddevin

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 3317
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 3144
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 1589
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 1324
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 1000
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4956
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_fixNormImplETI
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 665ede0
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d3eb291


CDash Test Results for PR# 4956.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit e1a1ff7 into develop Apr 19, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4956: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 19, 2019
@mhoemmen mhoemmen mentioned this pull request Apr 19, 2019
Closed
@kddevin kddevin mentioned this pull request Apr 19, 2019
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request May 17, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Jun 2, 2020
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees

@kddevin kddevin

Labels
pkg: Tpetra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kddevin @trilinos-autotester @mhoemmen