Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phalanx: fix unit test for cuda 12 #12359

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Phalanx: fix unit test for cuda 12 #12359

merged 1 commit into from
Oct 4, 2023

Conversation

rppawlo
Copy link
Contributor

@rppawlo rppawlo commented Oct 3, 2023

CUDA did not like an implicit lambda capture in constexpr if. Have to capture variables for the first time outside of the constexpr if in device lambdas.

@rppawlo
Phalanx: fix unit test for cuda 12
a8142a9 
CUDA did not like an implicit lambda capture in constexpr if. Have to
capture variables for the first time outside of the constexpr if.
@rppawlo rppawlo added pkg: Phalanx AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Oct 3, 2023
@rppawlo rppawlo requested a review from etphipp October 3, 2023 18:42
@rppawlo rppawlo self-assigned this Oct 3, 2023
@rppawlo rppawlo mentioned this pull request Oct 3, 2023
Closed
@eugeneswalker
Copy link

eugeneswalker commented Oct 3, 2023 •
edited
Loading

Thank you for this quick fix!

Just tried repeating the build using this PR, and I think this fixes #12341

I do run into this new error, but maybe you can confirm this is unrelated to the content of this PR and just another, separate issue relating to CUDA 12:

...
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_def.hpp: In instantiation of 'void Tpetra::CrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node>::fillLocalMatrix(const Teuchos::RCP<Teuchos::ParameterList>&) [with Scalar = long long int; LocalOrdinal = int; GlobalOrdinal = long long int; Node = Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Serial>]':
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/spack-build-xffgvc5/packages/tpetra/core/src/Tpetra_CrsMatrix_LONG_LONG_INT_LONG_LONG_SERIAL.cpp:74:16:   required from here
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_def.hpp:1689:70: error: no type named 'const_type' in 'cuda::std::__4::__is_primary_template<long long int>'
 1689 |         typename row_entries_type::const_type numRowEnt_h =
...
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/packages/kokkos/core/src/../../tpls/desul/include/desul/atomics/Operator_Function_Objects.hpp(75): warning #20011-D: calling a __host__ function("Teuchos::RCP<const  ::Tpetra::Export<int, long long,  ::Tpetra::KokkosCompat::KokkosDeviceWrapperNode< ::Kokkos::Cuda,  ::Kokkos::CudaSpace> > > ::RCP(const Teuchos::RCP<const  ::Tpetra::Export<int, long long,  ::Tpetra::KokkosCompat::KokkosDeviceWrapperNode< ::Kokkos::Cuda,  ::Kokkos::CudaSpace> > > &)") from a __host__ __device__ function("Tpetra::CrsGraph<int, long long,  ::Tpetra::KokkosCompat::KokkosDeviceWrapperNode< ::Kokkos::Cuda,  ::Kokkos::CudaSpace> > ::CrsGraph [subobject]") is not allowed

/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_def.hpp: In instantiation of 'void Tpetra::CrsMatrix<Scalar, LocalOrdinal, GlobalOrdinal, Node>::fillLocalMatrix(const Teuchos::RCP<Teuchos::ParameterList>&) [with Scalar = long long int; LocalOrdinal = int; GlobalOrdinal = long long int; Node = Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Cuda>]':
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/spack-build-xffgvc5/packages/tpetra/core/src/Tpetra_CrsMatrix_LONG_LONG_INT_LONG_LONG_CUDA.cpp:74:16:   required from here
/e4s-develop/collab/trilinos/ctest-cuda/Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_def.hpp:1689:70: error: no type named 'const_type' in 'cuda::std::__4::__is_primary_template<long long int>'
 1689 |         typename row_entries_type::const_type numRowEnt_h =
...

@rppawlo
Copy link
Contributor Author

rppawlo commented Oct 3, 2023

That's in a completely separate package that does not use phalanx. Definitely not related to this PR.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 3035
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1534
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1524
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1523
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2738
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2526
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 1165
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Using Repos:

Repo: TRILINOS (rppawlo/Trilinos)
  • Branch: phalanx-fix-cuda-12
  • SHA: a8142a9
  • Mode: TEST_REPO

Pull Request Author: rppawlo

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 3035
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 1534
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 1524
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 1523
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 2738
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 2526
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 1165
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: Phalanx;AT: AUTOMERGE;PA: Discretizations;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12359
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA a8142a9
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA e135b58


CDash Test Results for PR# 12359.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit f90adc4 into trilinos:develop Oct 4, 2023
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 12359: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 4, 2023
@rppawlo rppawlo deleted the phalanx-fix-cuda-12 branch October 4, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etphipp etphipp etphipp approved these changes

Assignees

@rppawlo rppawlo

Labels
AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Phalanx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rppawlo @eugeneswalker @trilinos-autotester @etphipp