-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intrepid2: fix for #12037. #12047
Intrepid2: fix for #12037. #12047
Conversation
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: CamelliaDPG |
thanks @CamelliaDPG ! Another lambda that creates troubles? I thought the support for lambda functions would be complete by now. |
Yes, this seems to be a recurring thing lately with these Data lambdas. I'm not sure what's going on -- the code has not changed substantively. I'd guess it's either a change to the way we're building (C++ 17, e.g.) with nvcc, and/or a new bug in nvcc itself, which manifests slightly differently on different platforms/versions of nvcc. But the fix, at least, is pretty straightforward. |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]! |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
…s:develop' (4539a08). * trilinos-develop: (61 commits) EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing Remove test for removed capability More fixes for tests after source_branch removal Phalanx: add some diagnostics for checking fencing with exec spaces ...
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (64 commits) Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion Panzer : Remove deprecated STK code. Fix some error message testing ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
…s:develop' (4539a08). * trilinos-develop: (66 commits) APREPRO: Fix -I parsing; use include_path on input file STK: Snapshot 07-17-23 09:42 from Sierra 5.15.2-314-g7c2d5cc9 Phalanx: fix exec space instance init for UVM=ON SEACAS: Fix for netcdf without pnetcdf EXODUS: Add a missed ifdef Sacado: Remove a few instances of use of deprecated Rank Sacado fix subview for LayoutContiguous<LayoutLeft> Intrepid2: fix for trilinos#12037; resolves a test failure on certain CUDA platforms. (PR trilinos#12047) EXODUS: Need to check whether nc_def_var_fill is defined in netCDF IOSS: Fix bad changes from !compare to != Use OpenMPI 1.10.1 for CXX20 build APREPRO: Fix "if" instead of "else if" in arg parsing IOSS: Remove fmt dependency for Trilinos users STK: Snapshot 07-12-23 07:43 from Sierra simon_2023-07-10-63-g4c25d07a Update logic for enabling TrilinosInstallTests in CI testing (trilinos#12024) Tempus: Example Problem to Use SolutionState Tempus: Example Problem to Use SolutionState Phalanx: only use partition_space if enough concurrency available Fix accidental debuggery Chomp usage whitespace before assertion ...
… CUDA platforms. (PR trilinos#12047)
@trilinos/intrepid2
Motivation
Fixes #12037 by replacing a lambda with a functor.
Testing
This fixes a failing test.