Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panzer, Tpetra: periodic bc communication has incorrect indices #7223

Closed
rppawlo opened this issue Apr 21, 2020 · 2 comments
Closed

Panzer, Tpetra: periodic bc communication has incorrect indices #7223

rppawlo opened this issue Apr 21, 2020 · 2 comments
Assignees
Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code PA: Data Services Issues that fall under the Trilinos Data Services Product Area PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Panzer pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests

Comments

@rppawlo
Copy link
Contributor

rppawlo commented Apr 21, 2020

Bug Report

@trilinos/panzer
@trilinos/tpetra
@kddevin

Description

For periodic BCs, the communication to send node information on a periodic sideset is losing values. We are seeing this when we exceed 128 cores on an empire problem. Local panzer unit testing is passing. exporting TPETRA_DEBUG=1 results in the output below. Since the maps were constructed with local and global sizes (not gid lists), the indices should be handled internally. The source map being constructed does not have entries on every node since the source represents a sideset.

The code in question starts on line 279 in:

Trilinos/packages/panzer/adapters-stk/src/stk_interface/Panzer_STK_PeriodicBC_Matcher.cpp

*********** Caught Exception: Begin Error Report ***********
MultiVector single-column pack kernel had 6721 out-of bounds index/ices.  Here they are: [-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -\
1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, \
-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,\
 -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1\
, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -\
1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, 

Steps to Reproduce

  1. SHA1: [insert here]
  2. Configure script: [attach here]
  3. Configure log: [attach here]
  4. Build log: [attach here]
  5. Input deck: [attach here]
  6. Do this.
  7. Do that.
  8. Shake fist angrily at computer.
  9. Run log: [attach here]
@rppawlo rppawlo added the type: bug The primary issue is a bug in Trilinos code or tests label Apr 21, 2020
@rppawlo rppawlo added client: EMPIRE All issues that most directly target the ATDM EMPIRE code PA: Data Services Issues that fall under the Trilinos Data Services Product Area PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Panzer pkg: Tpetra labels Apr 21, 2020
@kddevin
Copy link
Contributor

kddevin commented Apr 22, 2020

To confirm: you see this problem when building with Serial node on ceelan, right?

@rppawlo
Copy link
Contributor Author

rppawlo commented Apr 22, 2020

yes. this was identified before the kokkos 3.1 promotion as well.

kddevin added a commit that referenced this issue Apr 23, 2020
kddevin added a commit that referenced this issue Apr 25, 2020
Build several different maps; build DistributedContiguousDirectories from them;
getEntries for all Map entries; check for correctness
@kddevin kddevin closed this as completed May 12, 2020
kliegeois pushed a commit to kliegeois/Trilinos that referenced this issue May 29, 2020
kliegeois pushed a commit to kliegeois/Trilinos that referenced this issue May 29, 2020
Build several different maps; build DistributedContiguousDirectories from them;
getEntries for all Map entries; check for correctness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code PA: Data Services Issues that fall under the Trilinos Data Services Product Area PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Panzer pkg: Tpetra type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

2 participants