Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: configure error using COMPLEX_DOUBLE and FLOAT types #4857

Closed
ajpowel opened this issue Apr 10, 2019 · 7 comments
Closed

Tpetra: configure error using COMPLEX_DOUBLE and FLOAT types #4857

ajpowel opened this issue Apr 10, 2019 · 7 comments
Labels
impacting: configure or build The issue is primarily related to configuring or building pkg: Ifpack2 pkg: Thyra Issues primarily dealing with the Thyra Package

Comments

@ajpowel
Copy link

ajpowel commented Apr 10, 2019

@trilinos/Tpetra

Expectations

We do not want to turn on Trilinos_ENABLE_COMPLEX_FLOAT if we are also using Trilinos_ENABLE_FLOAT and Trilinos_ENABLE_COMPLEX_DOUBLE. Is the current behavior (below) correct?

Current Behavior

Processing enabled package: Tpetra (Classic, TSQR, Core)
-- Tpetra: Enabling deprecated code
-- Determine whether Tpetra will assume that MPI is CUDA aware:
-- - Tpetra_ENABLE_CUDA is OFF, so Tpetra will assume that MPI is not CUDA aware.
-- Tpetra execution space availability (ON means available):
-- - Serial: ON
-- - Threads: OFF
-- - OpenMP: OFF
-- - Cuda: OFF
CMake Error at packages/tpetra/CMakeLists.txt:986 (MESSAGE):
Tpetra: Tpetra_INST_COMPLEX_FLOAT is OFF (meaning that you want to disable
explicit instantiation and/or tests of Tpetra with Scalar =
std::complex), but Teuchos_ENABLE_COMPLEX is ON and
Teuchos_ENABLE_FLOAT is ON. This will cause downstream link errors, likely
in Thyra or Stratimikos. See GitHub Issue 4080 for details. Best
practice: Do NOT set Tpetra_INST_COMPLEX_FLOAT, Teuchos_ENABLE_COMPLEX, or
Teuchos_ENABLE_FLOAT explicitly. Instead, set
Trilinos_ENABLE_COMPLEX_FLOAT explicitly. That will set defaults for
Teuchos and Tpetra correctly.

-- Configuring incomplete, errors occurred!
See also "/scratch/ajpowel/code_032119/fix_trilly/CMakeFiles/CMakeOutput.log".
See also "/scratch/ajpowel/code_032119/fix_trilly/CMakeFiles/CMakeError.log".

Motivation and Context

Sierra-Trilinos integration

Steps to Reproduce

cmake -DTrilinos_ENABLE_Tpetra=ON -DTrilinos_ENABLE_COMPLEX_DOUBLE=ON -DTrilinos_ENABLE_FLOAT=ON -DTrilinos_ENABLE_Teuchos=ON $PATH_TO_MY_SOURCE_CODE
@sebrowne
Copy link
Contributor

@mhoemmen

@mhoemmen
Copy link
Contributor

@trilinos/tpetra

@sebrowne I'm in a phone call now. I doubt very much that Trilinos has any tests with Scalar=float and Scalar=complex<double> both enabled. I'm not sure how to fix this, other than by disabling the check that caused the error, and letting users who do the wrong thing with respect to Thyra settings. Is that OK?

@mhoemmen
Copy link
Contributor

In experimentation yesterday, when we disabled the configure-time check, we got the following build error: #4858

@mhoemmen mhoemmen added pkg: Thyra Issues primarily dealing with the Thyra Package pkg: Ifpack2 impacting: configure or build The issue is primarily related to configuring or building labels Apr 11, 2019
@mhoemmen mhoemmen mentioned this issue Apr 18, 2019
Merged
@mhoemmen
Copy link
Contributor

@ajpowel @sebrowne Update: I'm making some progress in my above PR, by setting the following CMake options:

Trilinos_ENABLE_FLOAT:BOOL=ON
Amesos2_ENABLE_Epetra:BOOL=OFF

@mhoemmen
Copy link
Contributor

@ajpowel @sebrowne @rrdrake
ShyLU's Frosch subpackage is quite broken with respect to this. Do y'all enable that?

@sebrowne
Copy link
Contributor

@mhoemmen we do not, and when I checked CMake's output, it appears that it's disabled as well.

@mhoemmen
Copy link
Contributor

This depends on PR #4955 and PR #4948.

mhoemmen added a commit that referenced this issue Apr 19, 2019
@mhoemmen
Merge pull request #4948 from trilinos/Fix-4857
07db02a 
Tpetra: Fix #4857
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Apr 19, 2019
Merge 'trilinos/Trilinos:develop' (0b91d1e) into 'tcad-charon/Trilino…
5a59cb3 
…s:develop' (7db7806).

* trilinos-develop: (125 commits)
  Phalanx:  Evalautor Typo Fix
  Belos,Ifpack2,ShyLU: Fix use of deprecated Tpetra features
  MueLu: fix link issue
  Tpetra: Fix trilinos#4857
  Tpetra::CrsGraph: Hide CrsGraphCopier in deprecated macro
  Tpetra::MultiVector: Hide MultiVectorCloner in deprecated macro
  Ifpack2: Fix use of deprecated Tpetra::Map constructor
  Tpetra,Ifpack2: Finish hiding methods deprecated by trilinos#2630
  IOSS: Fix name length handling one last time
  SUPES: Fix off-by-one error
  xpetra:  removed default types in deprecated code
  Set Trilinos_MAKE_INSTALL_WORLD_READABLE=ON by default (trilinos#2689)
  Automatic snapshot commit from tribits at 747ad3d
  KokkosKernels: Patching in test size reduction to D2GC unit test
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  Applied kokkos patches to get things compiling for cuda and bitsets for in place new
  MueLu: Continuing the Attack On The Clones
  Add RDC builds for CUDA 10.1 (TRIL-245)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Apr 20, 2019
Merge 'trilinos/Trilinos:develop' (8c5bac7) into 'tcad-charon/Trilino…
e0fdac0 
…s:develop' (7db7806).

* trilinos-develop: (128 commits)
  MueLu: Better configure time checks for matlab
  EXODUS: Fix a few off-by-one in copy_string (trilinos#4961)
  Phalanx:  Evalautor Typo Fix
  tpetra:  added scalar = int instantiation as suggested in trilinos#4951
  Belos,Ifpack2,ShyLU: Fix use of deprecated Tpetra features
  MueLu: fix link issue
  Tpetra: Fix trilinos#4857
  Tpetra::CrsGraph: Hide CrsGraphCopier in deprecated macro
  Tpetra::MultiVector: Hide MultiVectorCloner in deprecated macro
  Ifpack2: Fix use of deprecated Tpetra::Map constructor
  Tpetra,Ifpack2: Finish hiding methods deprecated by trilinos#2630
  IOSS: Fix name length handling one last time
  SUPES: Fix off-by-one error
  xpetra:  removed default types in deprecated code
  Set Trilinos_MAKE_INSTALL_WORLD_READABLE=ON by default (trilinos#2689)
  Automatic snapshot commit from tribits at 747ad3d
  KokkosKernels: Patching in test size reduction to D2GC unit test
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Apr 20, 2019
Merge 'trilinos/Trilinos:develop' (8c5bac7) into 'tcad-charon/Trilino…
a6a844d 
…s:develop' (7db7806).

* trilinos-develop: (128 commits)
  MueLu: Better configure time checks for matlab
  EXODUS: Fix a few off-by-one in copy_string (trilinos#4961)
  Phalanx:  Evalautor Typo Fix
  tpetra:  added scalar = int instantiation as suggested in trilinos#4951
  Belos,Ifpack2,ShyLU: Fix use of deprecated Tpetra features
  MueLu: fix link issue
  Tpetra: Fix trilinos#4857
  Tpetra::CrsGraph: Hide CrsGraphCopier in deprecated macro
  Tpetra::MultiVector: Hide MultiVectorCloner in deprecated macro
  Ifpack2: Fix use of deprecated Tpetra::Map constructor
  Tpetra,Ifpack2: Finish hiding methods deprecated by trilinos#2630
  IOSS: Fix name length handling one last time
  SUPES: Fix off-by-one error
  xpetra:  removed default types in deprecated code
  Set Trilinos_MAKE_INSTALL_WORLD_READABLE=ON by default (trilinos#2689)
  Automatic snapshot commit from tribits at 747ad3d
  KokkosKernels: Patching in test size reduction to D2GC unit test
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  MueLu: Fixing issue identified by Yingzhou Li (4927)
  ...
@trilinos-autotester trilinos-autotester mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impacting: configure or build The issue is primarily related to configuring or building pkg: Ifpack2 pkg: Thyra Issues primarily dealing with the Thyra Package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhoemmen @ajpowel @sebrowne