Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panzer example confiure out of date with package split #262

Closed
bathmatt opened this issue Apr 1, 2016 · 5 comments
Closed

panzer example confiure out of date with package split #262

bathmatt opened this issue Apr 1, 2016 · 5 comments
Assignees

Comments

@bathmatt
Copy link
Contributor

bathmatt commented Apr 1, 2016

@rppawlo the cmake stuff for main_driver didn't get updated correctly when panzer got split.

@rppawlo rppawlo self-assigned this Apr 1, 2016
@rppawlo
Copy link
Contributor

rppawlo commented Apr 1, 2016

I will take a look on Monday.

@rppawlo
Copy link
Contributor

rppawlo commented Apr 4, 2016

@bathmatt are you talking about the example build scripts in "Trilinos/packages/panzer/maintenance"?

@bathmatt
Copy link
Contributor Author

bathmatt commented Apr 4, 2016

IF (${PACKAGE_NAME}_BUILD_SOLVER_DRIVERS_EPETRA)
ADD_SUBDIRECTORY(main_driver)
ENDIF()
Trilinos/packages/panzer/adapters-stk/example

On Mon, Apr 4, 2016 at 8:58 AM, rppawlo [email protected] wrote:

@bathmatt https://github.com/bathmatt are you talking about the example
build scripts in "Trilinos/packages/panzer/maintenance"?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#262 (comment)

@rppawlo rppawlo added the stage: ready The issue is ready to be worked in a Kanban-like process label Apr 4, 2016
@rppawlo
Copy link
Contributor

rppawlo commented Apr 6, 2016

This was subtle. In the package split we change some optional dependencies (when it was all one package) to required dependencies for a particular subpackage. Tribits only defines the ENABLE* variables for optional dependencies, not required dependencies. So three panzer tests were automatically disabled due to a combined option check. Fixes are in place and being tested now.

@rppawlo rppawlo added stage: in progress Work on the issue has started and removed stage: ready The issue is ready to be worked in a Kanban-like process labels Apr 6, 2016
@rppawlo
Copy link
Contributor

rppawlo commented Apr 6, 2016

Just pushed the fix. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants