Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: build errors when enabling MueLu_ENABLE_Kokkos_Refactor #128

Closed
mhoemmen opened this issue Feb 4, 2016 · 4 comments
Closed

MueLu: build errors when enabling MueLu_ENABLE_Kokkos_Refactor #128

mhoemmen opened this issue Feb 4, 2016 · 4 comments

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Feb 4, 2016

@trilinos/muelu

When I enable MueLu_ENABLE_Kokkos_Refactor, I get build errors:

.../Trilinos/packages/muelu/src/Graph/MueLu_Aggregates_kokkos_def.hpp:111:51: error: no member named 'getLocalView' in 'Xpetra::Vector<int, int, int,
Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Threads, Kokkos::HostSpace> >'
auto procWinner = procWinner_ ->template getLocalView();
~~~~~~~~~~~ ^
.../Trilinos/packages/muelu/src/Graph/MueLu_Aggregates_kokkos_def.hpp:110:51: error: no member named 'getLocalView' in 'Xpetra::Vector<int, int, long
long, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Threads, Kokkos::HostSpace> >'
auto vertex2AggId = vertex2AggId_->template getLocalView();

The only reason I'm trying this is that I would like to enable the Xpetra vs. Epetra vs. Tpetra vs. Kokkos fill benchmark, mentioned in Issue #118. However, the benchmark is only enabled if MueLu_ENABLE_Kokkos_Refactor is ON.

@aprokop
Copy link
Contributor

aprokop commented Feb 4, 2016

Mark, you need to enable Kokkos Redactor in Xpetra too.

@aprokop
Copy link
Contributor

aprokop commented Feb 4, 2016

I pushed a commit to MueLu (756e9c5) that now throws an error if one forgot to enable Xpetra's Kokkos Refactor.

@aprokop aprokop closed this as completed Feb 4, 2016
@mhoemmen
Copy link
Contributor Author

mhoemmen commented Feb 5, 2016

Thanks Andrey! Hope I'm not being a pest! Does the example in question actually require the Kokkos refactor versions of Xpetra and MueLu? Could I guard the parts of it that do with macros?

@aprokop
Copy link
Contributor

aprokop commented Feb 5, 2016

On the contrary, I'm thankful to you for reporting these issues. It is much better to catch these things earlier.

The test really only requires Xpetra Kokkos Refactor, as getLocalMatrix in Xpetra is hidden behind the guard. The reason you need MueLu Kokkos Refactor is simply because the directory I put the test in is guarded by that. Feel free to copy the test to Tpetra if needed.

mhoemmen pushed a commit that referenced this issue Feb 5, 2016
@trilinos/tpetra This commit fixes Issue #132.

@aprokop wrote a benchmark in MueLu that compares performance of getting
local row views with Xpetra::CrsMatrix, Epetra_CrsMatrix,
Tpetra::CrsMatrix, and KokkosSparse::CrsMatrix.  See Issue #118 for
discussion.  The problem is that the benchmark lives in MueLu, and
requires enabling experimental build options which are off by default
(see Issue #128).  This motivated me to port the benchmark to Tpetra.

This commit adds the ported benchmark to Tpetra as an example.  The main
point of the benchmark is to compare Tpetra vs. Epetra vs. "raw" Kokkos
performance, so I left Xpetra out.

Build/Test Cases Summary
Enabled Packages: TpetraCore
Disabled Packages: FEI,STK,PyTrilinos,NOX,Teko,Piro
0) MPI_DEBUG => Test case MPI_DEBUG was not run! => Does not affect push readiness! (-1.00 min)
1) SERIAL_RELEASE => Test case SERIAL_RELEASE was not run! => Does not affect push readiness! (-1.00 min)
2) MPI_DEBUG_COMPLEX => passed: passed=86,notpassed=0 (3.94 min)
3) SERIAL_RELEASE => passed: passed=66,notpassed=0 (3.61 min)
bartlettroscoe added a commit that referenced this issue Apr 7, 2020
Origin repo remote tracking branch: 'github/master'
Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git'

At commit:

commit 985698642271403b89156809c25473afd3138ed0
Author:  Roscoe A. Bartlett <[email protected]>
Date:    Tue Apr 7 09:44:13 2020 -0400
Summary: Merge pull request #128 from nschloe/hdf5-parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants