Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: cmake error #10925

Closed
glhenni opened this issue Aug 24, 2022 · 7 comments
Closed

MueLu: cmake error #10925

glhenni opened this issue Aug 24, 2022 · 7 comments
Assignees
Labels
pkg: MueLu TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework type: bug The primary issue is a bug in Trilinos code or tests

Comments

@glhenni
Copy link
Contributor

glhenni commented Aug 24, 2022

Bug Report

@trilinos/<MueLu>

Not sure if this is a muelu error or a tribits error (@bartlettroscoe ?) but all our tests failed last night with:

Processing enabled package: MueLu (Libs)
-- MueLu: Enabling deprecated code
-- MueLu's tutorial requires for a correct build that if Tpetra is enabled, then GlobalOrdinal=int must be enabled, and either the Serial or OpenMP Nodes in Tpetra be enabled.  Since this is not the case, I am disabling MueLu's tutorial by default.  See Trilinos GitHub Issue #1726 for details: https://github.com/trilinos/Trilinos/issues/1726
CMake Error at /scratch/charonops/jenkins/workspace/ASCIC_Build_Farm_Heavy_CDE-GNU-opt/TriBITS/tribits/core/package_arch/TribitsAddOptionAndDefine.cmake:78 (tribits_pkg_export_cache_var):
  tribits_pkg_export_cache_var Macro invoked with incorrect arguments for
  macro named: tribits_pkg_export_cache_var
Call Stack (most recent call first):
  Trilinos/packages/muelu/CMakeLists.txt:166 (TRIBITS_ADD_OPTION_AND_DEFINE)


-- You chose to enable MueLu's tutorial, even though I told you that it may not build correctly.  You are responsible for whatever build or link errors may occur as a result.
@glhenni glhenni added the type: bug The primary issue is a bug in Trilinos code or tests label Aug 24, 2022
@cgcgcg
Copy link
Contributor

cgcgcg commented Aug 24, 2022

@trilinos/muelu

@bartlettroscoe
Copy link
Member

@glhenni, I discovered this last night. I am about to post the PR to fix this.

@bartlettroscoe bartlettroscoe self-assigned this Aug 24, 2022
@bartlettroscoe
Copy link
Member

NOTE: This is using the 'master' version of TriBITS which is not in Trilinos 'develop' yet.

@bartlettroscoe
Copy link
Member

@glhenni, PR TriBITSPub/TriBITS#521 just merged and it accidentally closed this issue because I put "Fixes #10925" in the text.

Please reopen this issue if you still find your Trilinos build is broken but I am pretty sure this should fix the issue.

@glhenni
Copy link
Contributor Author

glhenni commented Aug 24, 2022

Historically we've used tribits outside of trilinos, checking it out separately. TBH, I'm not exactly sure why. In this case once you fix it in Tribits/master we'll be good, so it works in our favor in this case.

@bartlettroscoe
Copy link
Member

Historically we've used tribits outside of trilinos, checking it out separately. TBH, I'm not exactly sure why. In this case once you fix it in Tribits/master we'll be good, so it works in our favor in this case.

@glhenni, there are pros and cons to using the tip of TriBITS 'master' with Trilinos (or any TriBITS project). I will try to remember that Charon is pulling the tip of TriBITS 'master' and do more testing against Trilinos before pushing to TriBITS 'master' in the future.

@glhenni
Copy link
Contributor Author

glhenni commented Aug 24, 2022

Everything is back up and running Ross. Really appreciate your speed in fixing it! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: MueLu TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework type: bug The primary issue is a bug in Trilinos code or tests
Projects
Status: Done
Development

No branches or pull requests

3 participants