Properly declare imported 'm' library

As per modern CMake recommendations, want to inform CMake that 'm' ('libm') is an imported library outside of the project. Necessary when using LINK_LIBRARIES_ONLY_TARGETS to allow CMake to error-check target dependencies (since this is now a target dependency and not a direct library dependency). User Support Ticket(s) or Story Referenced: TRILFRAME-601
trilinos · Oct 5, 2023 · 8c972a7 · 8c972a7
1 parent adb1dff
commit 8c972a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -97,6 +97,9 @@ SET(Trilinos_MUST_FIND_ALL_TPL_LIBS_DEFAULT TRUE)
 
 SET(CMAKE_LINK_LIBRARIES_ONLY_TARGETS ON)
 
+add_library(toolchain::m INTERFACE IMPORTED)
+set_property(TARGET toolchain::m PROPERTY IMPORTED_LIBNAME "m")
+
 # Set up C++ language standard selection
 include(SetTrilinosCxxStandard)
 

diff --git a/packages/common/auxiliarySoftware/SuiteSparse/src/CMakeLists.txt b/packages/common/auxiliarySoftware/SuiteSparse/src/CMakeLists.txt
@@ -77,7 +77,7 @@ ENDIF()
 # LibM not available under MSVC.
 IF(NOT MSVC)
   # Add libm linking for ceil, floor and such.
-  LIST(APPEND IMPORTEDLIBS m)
+  LIST(APPEND IMPORTEDLIBS toolchain::m)
 ENDIF()
 
 TRIBITS_ADD_LIBRARY(

diff --git a/packages/zoltan/src/CMakeLists.txt b/packages/zoltan/src/CMakeLists.txt
@@ -670,7 +670,7 @@ ENDIF()
 
 IF(NOT MSVC)
   # Add libm linking for ceil, floor and such.
-  LIST(APPEND IMPORTEDLIBS m)
+  LIST(APPEND IMPORTEDLIBS toolchain::m)
 ENDIF()
 
 TRIBITS_ADD_LIBRARY(