Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added multistream support #44

Closed
wants to merge 1 commit into from
Closed

added multistream support #44

wants to merge 1 commit into from

Conversation

andreycizov
Copy link
Contributor

No description provided.

@andreycizov andreycizov mentioned this pull request Jul 11, 2019
Open
alexcrichton
alexcrichton reviewed Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that the checks for zero need to be in slightly different locations, but otherwise looks good to me.

src/bufread.rs Outdated
{
let input = try!(self.obj.fill_buf());
eof = input.is_empty();
if input.is_empty() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for zlib this wasn't quite right where we need to wait for the decompress call below to return EOF before we return EOF to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreycizov @alexcrichton