Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation #114

Merged
merged 2 commits into from
Dec 9, 2024
Merged

update documentation #114

merged 2 commits into from
Dec 9, 2024

Conversation

folkertdev
Copy link
Collaborator

Mostly we can use newer rustdoc feature for more cross-linking. I also added docs on the feature flags in the readme.

Comment on lines -7 to -10
```toml
# Cargo.toml
[dependencies]
bzip2 = "0.4"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because crates.io shows you what to add and cargo add exists now. The risk of this snippet getting out of sync is high.

@folkertdev folkertdev requested a review from bjorn3 December 9, 2024 13:54
README.md Outdated

*`libbz2-rs-sys`*

Since version 0.5.0, this crate also supports using [libbz2-rs-sys](https://crates.io/crates/libbz2-rs-sys),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be kept out until right before 0.5 is actually released to avoid confusing people who are looking at the readme on github rather than on crates.io.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, to refer back to this later, the proposed text for the release is

Features

By default, this crate will compile the libbz2 C library from source. That requires a functional C toolchain,
and may not work for all targets (in particular webassembly).

libbz2-rs-sys

Since version 0.5.0, this crate also supports using libbz2-rs-sys,
a drop-in compatible rust implementation of libbz2. With this feature enabled, cross-compilation should work
like any other rust code, and no C toolchain is needed to compile this crate or its dependencies.

bzip2 = { version = "0.5.0", default-features = false, features = ["libbz2-rs-sys"] }

static

Statically links libbz2. When libbz2-rs-sys is enabled, static mode is always used.

src/lib.rs Outdated Show resolved Hide resolved
@folkertdev folkertdev merged commit fe3a545 into master Dec 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants