set msrv to 1.65.0 #111
Merged
set msrv to 1.65.0 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
set-msrv
branch
4 times, most recently
from
8a7709c to
13b81d0
Compare
|
Debian is currently at 1.63: https://packages.debian.org/bookworm/rustc Some packages choose the rustc available in the latest stable Debian release as MSRV. |
|
Right, I wanted to use that, because it is the earliest that the library itself compiles with, but the tests (the The changes in the next release are that some very deprecated stuff got removed, and we add the option for |
|
So you intend to make the next release 0.5.0? In that case LGTM. |
|
Yes we have to, we've removed api surface in #109 |
bjorn3
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in practice 1.65.0 is needed for our test suite. It's the version that stabilized
let-else, so it makes sense that dependencies would pick it as their msrv.