Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What ancillary df duplicates_taxa should contain? #26

Closed
damianooldoni opened this issue Dec 10, 2018 · 3 comments
Closed

What ancillary df duplicates_taxa should contain? #26

damianooldoni opened this issue Dec 10, 2018 · 3 comments
Assignees

Comments

@damianooldoni
Copy link
Collaborator

In old version of verify_taxa the df output duplicates_taxa contained taxa from different checklists which with same scientific name.
In new verify_taxa(), I propose to use duplicates_taxa to collect all taxa which point to same bb_key-bb_acceptedKey.

Example. The taxa here below would be in duplicates_taxa:

taxonKey scientificName bb_key bb_acceptedKey
1 A 10 15
2 B 10 15
3 C 10 15

Drawback of this implementation: taxa without match to GBIF Backbone would be not included. So the following two taxa which are very likely the same species, would be not returned in duplicates_taxa:

taxonKey scientificName bb_key bb_acceptedKey
4 E NA NA
5 E NA NA

I can live with that 😄 @peterdesmet : you too? It is actually a question about the meaning we want to give to the expression "duplicates taxa". As we use now a key-triplets (taxonkey - bb_key - bb_acceptedKey) to identify unique taxa instead of names, I think using bb_key - bb_acceptedKey sounds to be the best option.

@peterdesmet
Copy link
Member

As discussed, just using keys (and not names) for this df is fine. I would simply call the df “duplicates”

@damianooldoni
Copy link
Collaborator Author

Allright.

damianooldoni added a commit that referenced this issue Dec 12, 2018
Among others: some name changes as discussed in #26  and #27 and apply specific order to taxa in output dfs as discussed in #27.
damianooldoni added a commit that referenced this issue Dec 12, 2018
Changing name and solve bugs about outdated taxa
@damianooldoni
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants