-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Belgian occurrence indicators based on corrected cubes #128
Comments
Update: the links to the corrected cubes on zenodo have been added where necessary. However, two errors occurred
|
This olves the first of the two problems described in #128 (comment) Co-Authored-By: Pieter Huybrechts <[email protected]>
First problem solved via c6e5763 |
@damianooldoni I tried to rerun the 07_occurrence_indicators_modelling.Rmd script but still encountered the same error linked to the apply_gam function (column smooth doesn't exist). It has likely something to do with how I loaded the updated version of the trias package on my local computer (I fetched the main branch of trias-project/trias and did "update from main" in Github Desktop for the current branch linked to issue #128 of trias-project/indicators). As that still gave an error, I updated the trias package on my local computer but that also didn't work. Do you know if I still need to do something else? Thanks in advance! |
Hi @soriadelva. The
So, in general, it's just a question of checking versions of a package. This is a nice example why it's important to apply versioning in package development 😄 Please, don't hesitate to contact me here or via chat if something is not working or not clear. |
Thanks @damianooldoni, this worked! I ran all scripts and knit the respective .Rmd files. Before I generate a Pull Request, do you want me to commit all the files that have been overwritten by the changes? |
Did you remember to delete all existent images before generating the new ones? Yes, you can push the changes in some commits and then generate a Pull Request 👍 Thanks a lot. |
oh no, I didn't! 😓 I'll run it again!! |
Run occurrence based indicators on corrected cubes:
This means running all Rmds in
./src
from 5 to 12.The text was updated successfully, but these errors were encountered: