-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support model R emulators #178
Conversation
In 9622a46 I have included also the How to test it on MAC (I cannot try it on Nixos):
|
I will try to build a model R emulator on arm, if that works then there should be no reason it shouldn't work on m1. I will let you know here. |
Thanks. I think the |
728a857
to
c9ffcdd
Compare
c9ffcdd
to
82739d4
Compare
@grdddj is this ready to be reviewed and merged? Btw matejcik made a hotfix after the first trezorctl release (0.13.2), does this include that instead of the first version? |
In short - it is theoretically ready for review, but not yet ready for merge. It is missing some stuff I will do tomorrow - rebase on master, some testing the trezorlib works fine etc. |
Ok just ping me if this would wait for me please :). |
Reason is that changes in these should not invalidate local build - it saves time
82739d4
to
cd12226
Compare
f89a24d
to
c7e2e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could bikeshed some things but I do not think it is needed :). LGTM.
I will merge this on Wednesday due to the holidays. cc @mroz22 just so you know if you notice something odd on Suite side after the merge.
Connected with #176:
tenv
Is a little hacky, for couple of reasons/limitations:
trezorlib
formodel R
support, but it is unreleasedpoetry install
(known issue), so I am doing it manually throughpip
inDockerfile
as a last stepmodel R
emulator(s), but they are not yet releasedmaster
we do have it running, just with a very limited capabilitiesIt is however easily possible for anybody to download any branch through the
Start from URL
feature - just giving it URL to some Gitlab job ofcore unix frozen R debug build
(for example https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/jobs/2498092302) and choosingTR
.What is currently missing is support for
ARM
- sorry guys @vdovhanych @sime @tsusanka - but it could be possible to add somemodel R ARM build
infofirmware CI
:)