feat(mobile): FW update changelog modal #16205

Nodonisko · 2025-01-06T14:43:13Z

Description

Implement changelog bottom sheet + fix centering of Confirm on Trezor image on bottom of screen.

Related Issue

Resolve part of #15584
Resolve #16572

Screenshots:

github-actions · 2025-01-06T14:47:33Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 23
More info

Learn more about 𝝠 Expo Github Action

suite-native/intl/src/en.ts

suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx

suite-common/wallet-core/src/device/deviceReducer.ts

yanascz · 2025-01-24T08:51:54Z

suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx

+
+            let formattedText = text;
+
+            if (text.startsWith(' - ')) {


I guess you might want to do the same for '*' since it looks like this otherwise:

yanascz · 2025-01-24T09:23:45Z

suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx

+        }
+
+        if (typeof firmwareChangelog === 'string') {
+            return <Text>{firmwareChangelog}</Text>;


It seems that formatting may also be used in this case.

I went though changelogs in trezor/data repo and I haven't seen any single occurence of formatting so I won't be doing now, in future we may need to use full fledged markdown library, but for now it looks like overkill to me.

suite-common/wallet-core/src/device/deviceReducer.ts

yanascz · 2025-01-24T09:59:24Z

suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx

+            const key = text + index;
+
+            if (text.startsWith('#')) {
+                const strippedText = text.replaceAll('#', '').trim();


In case the # symbol is somewhere in the text, it'll be remove as well.

I made whole parser more robust using regexp so it should work correctly.

matejkriz

The text alignment on the line break is not perfect, but I would consider it a nitpick and I don't believe it's worth fixing now. I think we might consider the full Markdown support later together with the decoupling of the FW release from the Suite release (fetching releases.json remotely).

STew790 · 2025-02-06T10:32:45Z

QA OK
LGTM

Info
25.1.3 dde03ca

coderabbitai · 2025-02-06T10:35:52Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a new selector function, selectFirmwareChangelog, in the device reducer to retrieve the appropriate firmware changelog based on whether the device uses Bitcoin-only firmware. It adds new localizable strings in the firmware update screen, detailing button labels, titles, and messages for cases where the changelog is unavailable. Two new React components—FirmwareChangelog and FirmwareChangelogButton—are implemented. The FirmwareChangelog component renders the changelog in a bottom sheet interface, while the FirmwareChangelogButton handles user interaction to display the changelog. Finally, the firmware update screen is updated to incorporate the new button and adjust layout spacing.

Assessment against linked issues

Objective	Addressed	Explanation
Firmware update changelog is not showing (#16572)	✅

Possibly related PRs

Feat/suite handle fw update check #16477: Involves changes in firmware update actions and structures that relate to the new changelog selector.
feat(suite): show FW hash check other-error when debug settings #16733: Modifies firmware update functionality using selectors, similar to the approach taken in the new selector function.
feat(suite-native): add DeviceCompromisedModal for FW revision check #16722: Connects closely as it involves the usage of the selectFirmwareChangelog selector within a component that displays the firmware changelog.

Suggested reviewers

Nodonisko
MiroslavProchazka
komret

Tip

🌐 Web search-backed reviews and chat

We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
You can disable this feature by setting web_search: false in the knowledge_base settings.
Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c602de and 0d21789.

📒 Files selected for processing (5)

suite-common/wallet-core/src/device/deviceReducer.ts (1 hunks)
suite-native/intl/src/en.ts (1 hunks)
suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx (1 hunks)
suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelogButton.tsx (1 hunks)
suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareUpdateScreen.tsx (2 hunks)

✨ Finishing Touches

📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Nodonisko requested a review from a team as a code owner January 6, 2025 14:43

Nodonisko added the mobile Suite Lite issues and PRs label Jan 6, 2025

Nodonisko changed the title ~~fix(mobile): confirm on trezor image correctly centered~~ feat(mobile): FW update changelog modal Jan 6, 2025

matejkriz assigned Nodonisko Jan 7, 2025

yanascz reviewed Jan 8, 2025

View reviewed changes

suite-native/intl/src/en.ts Show resolved Hide resolved

yanascz reviewed Jan 8, 2025

View reviewed changes

suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareChangelog.tsx Outdated Show resolved Hide resolved

vytick reviewed Jan 8, 2025

View reviewed changes

suite-common/wallet-core/src/device/deviceReducer.ts Show resolved Hide resolved

Nodonisko force-pushed the feat/fw-changelog branch 2 times, most recently from a66536a to b95f79c Compare January 23, 2025 17:08

PeKne added the release-native Has to be included in the upcoming release. label Jan 24, 2025

yanascz reviewed Jan 24, 2025

View reviewed changes

suite-common/wallet-core/src/device/deviceReducer.ts Show resolved Hide resolved

yanascz reviewed Jan 24, 2025

View reviewed changes

PeKne removed the release-native Has to be included in the upcoming release. label Jan 24, 2025

Nodonisko force-pushed the feat/fw-changelog branch from b95f79c to 7660859 Compare January 29, 2025 11:44

feat(mobile): FW update changelog

0d21789

Nodonisko force-pushed the feat/fw-changelog branch from 7660859 to 0d21789 Compare January 29, 2025 12:01

matejkriz approved these changes Jan 29, 2025

View reviewed changes

Nodonisko merged commit 313c85a into develop Jan 30, 2025
33 of 35 checks passed

Nodonisko deleted the feat/fw-changelog branch January 30, 2025 12:40

STew790 added the QA OK Issue passed QA without any blocker label Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mobile): FW update changelog modal #16205

feat(mobile): FW update changelog modal #16205

Nodonisko commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading

yanascz Jan 24, 2025

yanascz Jan 24, 2025

Nodonisko Jan 29, 2025

yanascz Jan 24, 2025

Nodonisko Jan 29, 2025

matejkriz left a comment

STew790 commented Feb 6, 2025

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

feat(mobile): FW update changelog modal #16205

feat(mobile): FW update changelog modal #16205

Conversation

Nodonisko commented Jan 6, 2025 • edited Loading

Description

Related Issue

Screenshots:

github-actions bot commented Jan 6, 2025 • edited Loading

yanascz Jan 24, 2025

Choose a reason for hiding this comment

yanascz Jan 24, 2025

Choose a reason for hiding this comment

Nodonisko Jan 29, 2025

Choose a reason for hiding this comment

yanascz Jan 24, 2025

Choose a reason for hiding this comment

Nodonisko Jan 29, 2025

Choose a reason for hiding this comment

matejkriz left a comment

Choose a reason for hiding this comment

STew790 commented Feb 6, 2025

coderabbitai bot commented Feb 6, 2025 • edited Loading

Review failed

Walkthrough

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Nodonisko commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)