fix(core): Hold-to-confirm EIP-1559 transaction #2066
Closed
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Ethereum EIP-1559 transaction a hold-to-confirm transaction.
aloisklink
force-pushed
the
hold-to-send-eip1559
branch
from
0a1a2ca to
cfbabf5
Compare
|
Thanks, but the final screen should look a little different, and it was faster to implement than to comment :) closing in favor of #2103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the final Ethereum EIP-1559 transaction screen a hold-to-confirm (see screenshot below).
I saw a comment from @matejcik (below) and realised that EIP-1559 transactions don't have hold-to-confirm, so I thought I'd add them since I had already learned how to add hold-to-confirm to screens.
Edit: Force-pushed to add
.changelog.dentryedited: fixes #2020