Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Add CI tests for Ethereum plugin #1050

Closed
wants to merge 4 commits into from
Closed

Add CI tests for Ethereum plugin #1050

wants to merge 4 commits into from

Conversation

aloisklink
Copy link
Contributor

Adds CI tests for the Ethereum plugin (as discussed in #1033 (comment))

I've added the test to both GitHub Actions and GitLab CI. However, I've never used GitLab CI before, so I'm not 100% sure if this would work.

@mroz22
Copy link
Contributor

mroz22 commented Feb 16, 2022 •
edited
Loading

Hi, I ran your PR in gitlab CI (which is not triggered automatically for 3rd party)

But all good, we don't need to run it in gitlab that much. It actually makes best sense in github (which is triggered for 3rd party) as these plugins are develop mostly by 3rd party.

@aloisklink
Copy link
Contributor Author

Hi @mroz22,

Thanks for trying to fix the GitLab issues!

It looks like https://gitlab.com/satoshilabs/trezor/connect/-/jobs/2099096538 was just running on a generic busybox Docker image (probably the default one), which didn't have nix-shell installed.

Preparing the "docker" executor
Using Docker executor with image busybox ...

I've added image: registry.gitlab.com/satoshilabs/trezor/trezor-user-env/trezor-user-env:latest, so it should hopefully now run on your Trezor Env Docker image, which contains nix-shell.

connect/.gitlab-ci.yml

Lines 210 to 212 in 118e6b3

# Required only to make the `nix-shell` command available
# Alternatively, we could replace with generic `image: nixos/nix:latest`
image: registry.gitlab.com/satoshilabs/trezor/trezor-user-env/trezor-user-env:latest

If it still doesn't work (and since you said GitLab CI isn't as important as GitHub CI), I git rebase-ed to split up the GitHub and GitLab CI changes into two different commits, so it's easy to just delete the latest commit.

aloisklink and others added 4 commits March 14, 2022 02:49
@aloisklink
chore(plugins/ethereum): Set package.json private
14dddfa 
This is to ensure that nobody with publish
permissions at @trezor accidentally publishes
the ethereum plugin and overwrites the actual connect
package

See: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#private
@aloisklink
test(plugins/ethereum): Improve test names
b0fef6a 
Each test now has a unique name, taken from the fixture name.
@aloisklink
ci(plugins/ethereum): Enable GitHub CI tests
de7ff12 
Enabled CI tests on GitHub Actions runner for
Ethereum Plugin.
@aloisklink @mroz22
ci(plugins/ethereum): Enable GitLab CI tests
c69f0ba 
Enabled CI tests on GitLab for Ethereum plugin.

Co-authored-by: mroz <[email protected]>
@aloisklink aloisklink mentioned this pull request Mar 19, 2022
Merged
@mroz22 mroz22 mentioned this pull request Apr 6, 2022
Closed
4 tasks
@mroz22
Copy link
Contributor

mroz22 commented Jun 23, 2022

Hello, these tests are already part of trezor-suite monorepo so we can close it here. Thanks for contribution!

@mroz22 mroz22 closed this Jun 23, 2022
@aloisklink aloisklink deleted the ci-test-plugins branch June 23, 2022 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aloisklink @mroz22