This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Add t1 eip 712 support #1015
Merged
Add t1 eip 712 support #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
matejcik
reviewed
Jan 13, 2022
There was a problem hiding this comment.
general note: we have trezor/trezor-firmware#2036 in the pipeline, which makes message_hash optional in case primary_type == "EIP712Domain" (in this case message should be supplied but it can be {}
once that is in, Connect should support that usecase, namely something like:
if primaryType == "EIP712Domain" {
message_hash = null
}i'll leave it to you if we want to future-proof the Connect code right now, or if we want to release as-is and push an update later
mroz22
force-pushed
the
add-t1-eip-712-support
branch
10 times, most recently
from
e35f077 to
8ea81d9
Compare
szymonlesisz
approved these changes
Jan 13, 2022
mroz22
force-pushed
the
add-t1-eip-712-support
branch
from
8ea81d9 to
c7662de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #986